getInitialProps makes 404 and search render as SSR

[colbyfayock]

We're using getInitialProps in _app.js to allow us to have a "global" data layer

Beyond the general recommendation to steer away from it to use newer methods, turns out if you use it and your page doesn't use any other data fetching method, it assumes SSR

We need to add simple stubs of static props on any pages not using any data fetching simply to turn on static generation for those pages

export async function getStaticProps() {
  return {
    props: {},
  };
}

Pages that need this added:

• /search
• /404

Please confirm by running build that all pages are statically generated

[colbyfayock]

@GuilleAngulo this is why we were having issues with the 404 page

[GuilleAngulo]

Oh thats a great discover! and at the same time somehow disappointing having to set this boilerplate to achieve that😞

[petercr]

Hey Colby 🙋‍♂️
I would love to put in a fix for this issue.

It seems pretty straight forward, let me know if you want me to write up a PR for it 👍🏻

Thanks,

Pete

[colbyfayock]

Go for it! All yours

On Sun, Oct 3, 2021 at 10:58 AM Peter Cruckshank ***@***.***> wrote: Hey Colby 🙋‍♂️ I would love to put in a fix for this issue. It seems pretty straight forward, let me know if you want me to write up a PR for it 👍🏻 Thanks, Pete — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#212 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAH7GGTODDYSQLGUL2CVCALUFBVSJANCNFSM5AKNNFJQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

-- colbyfayock.com

[petercr]

Hey @colbyfayock I went ahead and moved getStaticProps( ) to the end of those components like you asked.

It should be good to go know 👌

[colbyfayock]

Fixed via #252