-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support the versioning system from apt #117
Conversation
Thanks for the pull request! We will take some time to review this soon. This appears related to #118 |
It probably makes sense to add this here, since Relevant manpage quote: "A specific version of a package can be selected for installation by https://linux.die.net/man/8/apt-get In the future, to support |
I agree to do this in the future. I might open another PR when I find the time. |
Yes, we can merge this. I'm going to write a unit test so we can make sure this functionality doesn't break when other changes are made. |
Unit test added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for the updates.
As apt is capable of using versions of packages, it would be great to have the same capability in colcon. Just as you could install any apt package by "apt install =", this could be defined in a corresponding rosdep.yaml and therefore here as well.