Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the versioning system from apt #117

Merged
merged 9 commits into from
Nov 15, 2019

Conversation

mulino-bianco
Copy link
Contributor

As apt is capable of using versions of packages, it would be great to have the same capability in colcon. Just as you could install any apt package by "apt install =", this could be defined in a corresponding rosdep.yaml and therefore here as well.

@murphm8
Copy link
Collaborator

murphm8 commented Oct 15, 2019

Thanks for the pull request! We will take some time to review this soon.

This appears related to #118

@murphm8
Copy link
Collaborator

murphm8 commented Oct 17, 2019

It probably makes sense to add this here, since <package name>=<version> is a valid command line argument to apt-get.

Relevant manpage quote: "A specific version of a package can be selected for installation by
following the package name with an equals (=) and the version of the package to select."

https://linux.die.net/man/8/apt-get

In the future, to support package.xml version specifiers I would probably prefer to use the metadata and consume the version information that way.

@mulino-bianco
Copy link
Contributor Author

I agree to do this in the future. I might open another PR when I find the time.
So will you merge this one?

@murphm8
Copy link
Collaborator

murphm8 commented Oct 17, 2019

Yes, we can merge this. I'm going to write a unit test so we can make sure this functionality doesn't break when other changes are made.

@murphm8
Copy link
Collaborator

murphm8 commented Oct 21, 2019

Unit test added.

@murphm8 murphm8 requested review from cgibb and removed request for cgibb October 21, 2019 16:28
colcon_bundle/installer/apt.py Outdated Show resolved Hide resolved
colcon_bundle/installer/apt.py Outdated Show resolved Hide resolved
test/installer/test_apt_installer.py Outdated Show resolved Hide resolved
test/installer/test_apt_installer.py Outdated Show resolved Hide resolved
colcon_bundle/installer/apt.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@samuelgundry samuelgundry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants