Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not look for version number on editable pip packages #39

Merged
merged 7 commits into from
Mar 7, 2019

Conversation

cgibb
Copy link
Collaborator

@cgibb cgibb commented Mar 5, 2019

If the user has a local python site and installed editable packages,
they will appear in the output of pip freeze in a different format
than other installed packages.

Testing

Tested on Ubuntu as normal user with an editable copy of colcon-bundle installed. colcon bundle succeeds in my catkin workspace.

If the user has a local python site and installed editable packages,
they will appear in the output of `pip freeze` in a different format
than other installed packages.
@cgibb cgibb requested a review from murphm8 March 5, 2019 03:08
@murphm8
Copy link
Collaborator

murphm8 commented Mar 5, 2019

Hmm, so does this mean that pip freeze is giving us the versions of all the packages installed into the local environment and the bundle?

@cgibb
Copy link
Collaborator Author

cgibb commented Mar 5, 2019

The python interpreter in the bundle is actually also pulling in the system pip module rather than the one in the bundle.

When running from my workspace:

$ ./bundle/bundle_staging/usr/bin/python3 -m pip --version
pip 19.0.3 from $HOME/.local/lib/python3.5/site-packages/pip (python 3.5)

So an alternative could be altering the python path configuration.

@murphm8
Copy link
Collaborator

murphm8 commented Mar 6, 2019

Per our discussion: We should use the command line options to ignore the system paths when invoking Python.

@cgibb
Copy link
Collaborator Author

cgibb commented Mar 7, 2019

Fixed the formatting and merged in latest changes from /master.

I haven't figured out a way to ignore the system paths and still produce a proper bundle, so I think the solution here is what we should use for now (as system libraries haven't been causing any other problems that we know of).

@murphm8
Copy link
Collaborator

murphm8 commented Mar 7, 2019

I filed #40 to follow up on the issues exposed in this PR.

@cgibb cgibb merged commit ffd1d81 into colcon:master Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants