-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not look for version number on editable pip packages #39
Conversation
If the user has a local python site and installed editable packages, they will appear in the output of `pip freeze` in a different format than other installed packages.
Hmm, so does this mean that |
The python interpreter in the bundle is actually also pulling in the system pip module rather than the one in the bundle. When running from my workspace:
So an alternative could be altering the python path configuration. |
Per our discussion: We should use the command line options to ignore the system paths when invoking Python. |
Fixed the formatting and merged in latest changes from /master. I haven't figured out a way to ignore the system paths and still produce a proper bundle, so I think the solution here is what we should use for now (as system libraries haven't been causing any other problems that we know of). |
I filed #40 to follow up on the issues exposed in this PR. |
If the user has a local python site and installed editable packages,
they will appear in the output of
pip freeze
in a different formatthan other installed packages.
Testing
Tested on Ubuntu as normal user with an editable copy of
colcon-bundle
installed.colcon bundle
succeeds in my catkin workspace.