Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is the current minimal requirements of colcon to use all the features? #20

Closed
mikaelarguedas opened this issue Apr 19, 2018 · 3 comments
Labels
question Further information is requested

Comments

@mikaelarguedas
Copy link
Contributor

Knowing the minimal requirements of this tool (such as pytest version) would help us evaluate the different packaging options.

We know pip packages tend to not be updated by users (I always forget to upgrade them) and it would be very valuable to be able to ship this tool as a deb.

@mikaelarguedas mikaelarguedas added the question Further information is requested label Apr 19, 2018
@dirk-thomas
Copy link
Member

The following changes have been merged:

Once Debian packages exist and instructions for using them are being added they need to mention that pytest-repeat and pytest-rerunfailures need to be installed from PIP.

Is there anything else which should be addressed for this ticket? Otherwise I think it can be closed.

@mikaelarguedas
Copy link
Contributor Author

With colcon/colcon.readthedocs.org#15 this issue is addressed as we have a list of all the dependencies.
This is still missing the minimal versions needed to use all the features, but from my understanding this will be addressed once the package is released.
@dirk-thomas please comment here if this doesn't match your understanding

@dirk-thomas
Copy link
Member

If there are specific minimum versions required those should be explicitly stated in the setup.cfg files of each package as well as in the requirements.txt file (see https://github.com/colcon/colcon.readthedocs.org/blob/master/requirements.txt). Atm I don't see specific version numbers necessary.

I can imagine that it wouldn't work with much older setuptools / pytest versions but the exact constraint are unknown to be at the moment. If we know any specific thresholds they should be added to those files with a brief comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Development

No branches or pull requests

2 participants