-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use newer pytest(-cov) features only when available #39
Conversation
b90ca9d
to
f2cf7a7
Compare
Codecov Report
@@ Coverage Diff @@
## master #39 +/- ##
==========================================
- Coverage 77.61% 77.39% -0.22%
==========================================
Files 48 48
Lines 2519 2526 +7
Branches 400 402 +2
==========================================
Hits 1955 1955
- Misses 550 557 +7
Partials 14 14
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pytest_cov check is actually checking the pytest version and not pytest_cov
PR description should refer to pytest 3.3.0 and not 3.5.0
] | ||
# use --cov-branch option only when available | ||
# https://github.com/pytest-dev/pytest-cov/blob/v2.5.0/CHANGELOG.rst | ||
from pytest import __version__ as pytest_cov_version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be from pytest_cov import ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Fixed in eddec1e. Please re-review.
f2cf7a7
to
d928c10
Compare
d928c10
to
eddec1e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
-o ...
as ofpytest
version 3.3.0--cov-branch
as ofpytest-cov
version 2.5.0