use newer pytest(-cov) features only when available #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirk-thomas
added
enhancement
dirk-thomas
force-pushed
the
conditional_pytest_features
branch
from
b90ca9d
to
f2cf7a7
Compare
Codecov Report
@@ Coverage Diff @@
## master #39 +/- ##
==========================================
- Coverage 77.61% 77.39% -0.22%
==========================================
Files 48 48
Lines 2519 2526 +7
Branches 400 402 +2
==========================================
Hits 1955 1955
- Misses 550 557 +7
Partials 14 14
Continue to review full report at Codecov.
|
sloretz
approved these changes
May 2, 2018
mikaelarguedas
suggested changes
May 3, 2018
| ] | ||
| # use --cov-branch option only when available | ||
| # https://github.com/pytest-dev/pytest-cov/blob/v2.5.0/CHANGELOG.rst | ||
| from pytest import __version__ as pytest_cov_version |
There was a problem hiding this comment.
Should be from pytest_cov import ...
There was a problem hiding this comment.
Good catch! Fixed in eddec1e. Please re-review.
dirk-thomas
force-pushed
the
conditional_pytest_features
branch
from
f2cf7a7
to
d928c10
Compare
dirk-thomas
force-pushed
the
conditional_pytest_features
branch
from
d928c10
to
eddec1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-o ...as ofpytestversion 3.3.0--cov-branchas ofpytest-covversion 2.5.0