Don't use pseudoterminal

[rotu]

I'm not sure why we use pseudoterminals, so here's a PR to remove them and see what breaks :-)

[codecov]

Codecov Report

Merging #323 into master will increase coverage by 0.51%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #323      +/-   ##
==========================================
+ Coverage   79.61%   80.13%   +0.51%     
==========================================
  Files          55       55              
  Lines        3209     3181      -28     
  Branches      534      522      -12     
==========================================
- Hits         2555     2549       -6     
+ Misses        607      593      -14     
+ Partials       47       39       -8

Impacted Files	Coverage Δ
colcon_core/task/__init__.py	98.98% <ø> (ø)	⬆️
colcon_core/subprocess.py	79.59% <100%> (+12.92%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af7fa08...4078610. Read the comment docs.

[rotu]

@dirk-thomas seeing as all tests pass, is there a reason this is a bad idea?

[dirk-thomas]

Until 2h ago the PR was markes as WIP so I didn't look at it until now because of that.

I will review the PR once I have time to do so. At the moment there are several other tasks with higher priority though.

[rotu]

Absolutely :-) I had it marked as WIP since I was sure I was wrong. There must have been some reason to do it "the hard way", but after digging, I couldn't figure out why.

[dirk-thomas]

Please see the reply to your original question: colcon/colcon-cmake#67 (comment)

Since this change breaks functionality I will go ahead and close the PR as invalid.

[dirk-thomas]

See colcon/colcon-cmake#67 (comment) for a proposal for a backward compatible transition.