Updates module support #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mrigsby I'm just now seeing this. I'll take a look through the changes and report back. Thanks for the PR! |
Thanks, hopefully it's up to par and helpful :-) |
|
@mrigsby This looks really good! I made a few changes as I noticed issues if you tried to reference a subfolder within a module, such as: #wire( "folder.myComponent@myModule" )#. I added tests to cover all the scenerios. I'll be doing some more testing and will merge soon. Thanks so much for your help!
|
|
@grantcopley Glad to help where I can. I really love cbwire. Thank you for all your work! |
grantcopley
approved these changes
Oct 20, 2023
grantcopley
merged commit e34e12e
into
coldbox-modules:development
3 of 4 checks passed
|
Thanks @grantcopley, I'm glad I could contribute! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated wire@module support to allow using #wire( "wire@module" )# outside of the module the wire exists in.
If just the wire name is used from inside a module and the wire does not exist in the current module, it looks for a matching wire name in the root wire location and if found uses it.
Note: commit 111a220 is supposed to be "added regex for SAFE wire name"