CancelledError thrown when trying to send without authentication

[wombatonfire]

If we try to send_message(msg) through the server, which requires login(), without logging in, a CancelledError will be thrown:

smtp_client = aiosmtplib.SMTP('smtp.office365.com', 587)
await smtp_client.connect()
await smtp_client.starttls()
# await smtp_client.login(username, password)
await smtp_client.send_message(msg)

Traceback:

  File "C:/Users/user/projects/sandbox/mailertest.py", line 514, in run
    await smtp_client.send_message(msg)
  File "C:\Anaconda\envs\sandbox\lib\site-packages\aiosmtplib\smtp.py", line 299, in send_message
    timeout=timeout,
  File "C:\Anaconda\envs\sandbox\lib\site-packages\aiosmtplib\smtp.py", line 174, in sendmail
    await self.rset(timeout=timeout)
  File "C:\Anaconda\envs\sandbox\lib\site-packages\aiosmtplib\esmtp.py", line 128, in rset
    response = await self.execute_command(b"RSET", timeout=timeout)
  File "C:\Anaconda\envs\sandbox\lib\site-packages\aiosmtplib\connection.py", line 420, in execute_command
    response = await self.protocol.execute_command(*args, timeout=timeout)
  File "C:\Anaconda\envs\sandbox\lib\site-packages\aiosmtplib\protocol.py", line 291, in execute_command
    response = await self.read_response(timeout=timeout)
  File "C:\Anaconda\envs\sandbox\lib\site-packages\aiosmtplib\protocol.py", line 259, in read_response
    self._response_waiter, timeout
  File "C:\Anaconda\envs\sandbox\lib\asyncio\tasks.py", line 442, in wait_for
    return fut.result()

While, obviously, you should not forget to authenticate to the server, if it requires you to, throwing CancelledError doesn't seem to me as the correct behavior. I would expect to get some sort of SMTPException instead. In fact, while testing, I got SMTPSenderRefused on multiple occasions, but most of the time CancelledError is raised.

[cole]

Agree, that's confusing. The connection is being lost, but CancelledError isn't helpful there. Please try the current main branch (if you can) and see if the issue persists for you; it should now raise SMTPSenderRefused, since that's the point where the server raised an error.

[cole]

1.1.5 is out now, should no longer raise CancelledError.