Do not specify a reconnect argument to mysql ping() if on mysql 8.

Replaces #2835
coleifer · Feb 5, 2024 · dff8fbc · dff8fbc
1 parent 5e42c67
commit dff8fbc
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/peewee.py b/peewee.py
@@ -4227,8 +4227,12 @@ def is_connection_usable(self):
 
         conn = self._state.conn
         if hasattr(conn, 'ping'):
+            if self.server_version[0] == 8:
+                args = ()
+            else:
+                args = (False,)
             try:
-                conn.ping(False)
+                conn.ping(*args)
             except Exception:
                 return False
         return True

diff --git a/playhouse/pool.py b/playhouse/pool.py
@@ -259,8 +259,12 @@ def close_all(self):
 
 class PooledMySQLDatabase(PooledDatabase, MySQLDatabase):
     def _is_closed(self, conn):
+        if self.server_version[0] == 8:
+            args = ()
+        else:
+            args = (False,)
         try:
-            conn.ping(False)
+            conn.ping(*args)
         except:
             return True
         else: