Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback gracefully in the face of ancient (and probably broken) Cython versions #821

Closed
wants to merge 3 commits into from

Conversation

jherre
Copy link

@jherre jherre commented Jan 15, 2016

Some folks have dependencies that won't support easy Cython upgrades. Ignore incompatible Cython installations - same thing as not having it at all...

Tested on py27, py34 and py35 and all versions of Cython up to 0.23.4

@coleifer
Copy link
Owner

Where did you arrive at that version number? I'm leery of merging this as I think it might cause some false positives.

@jherre
Copy link
Author

jherre commented Jan 15, 2016

I ran a matrix of all versions of Cython since 0.21 using py27, py34 and py35 using the peewee tests.

Using versions prior to 0.22.1 doesn't work. Failures happen during cythonization. If it's able to install, all tests pass. Trying to install peewee with any version prior to Cython==0.21.1 will fail.

@coleifer
Copy link
Owner

What about py26? Peewee officially supports python 2.6.

@jherre
Copy link
Author

jherre commented Jan 15, 2016

Yep, same result on python26. Using versions of Cython earlier than 0.21.1 will cause setup to fail.

It's really about what versions of Cython you're will to support for speedups. I think it's fair to say that folks need to upgrade to use the speedups in peewee but it's not fair to say they have to upgrade just to use peewee at all...

FWIW, Cython 0.22.1 was released 2014-10-18 which is really not that long ago in Python2.6 terms.

@coleifer coleifer closed this in 35304d2 Jan 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants