D9 - Fix js validation on required checkbox fields #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Incorrect validation submitting webform with mandatory checkboxes
Before
If a checkbox field is populated after selecting a contact in the autocomplete field, the required attribute still complains of being required even if an option is checked using ajax.
After
Form submits without any validation error.
Technical Details
Looks like webform assigns required=required attribute to the first checkbox element. Triggering a change event on the 3rd checkbox does not toggle the required attribute from the first option. Hence removing it separately.
Comments
Related drupal ticket - https://www.drupal.org/project/webform_civicrm/issues/3355974