Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix check for billing email when contributor isn't contact 1 #882

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

MegaphoneJon
Copy link
Contributor

Overview

The check for billing address email still assumes contact 1 is always the contributor.

Steps to replicate:

  • Create a webform with two contacts and a contribution.
  • Contributor should be contact 2.
  • Set "Number of Emails" for contact 1 to 0, and "Number of Emails" for contact 2 to 1 or more.
  • Try to submit the payment.

Before

Error: An email address is required to complete this transaction.

After

No error.

Technical Details

Not all of the references to contact 1 were replaced by a reference to the contributor contact.

@KarinG KarinG merged commit 2e66821 into colemanw:6.x Jun 8, 2023
5 checks passed
@MegaphoneJon MegaphoneJon deleted the billing-email-check branch June 8, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants