Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"gc_get_refs(gc): -1" debug prints on stdout #53

Closed
ogrisel opened this issue Apr 20, 2022 · 3 comments
Closed

"gc_get_refs(gc): -1" debug prints on stdout #53

ogrisel opened this issue Apr 20, 2022 · 3 comments

Comments

@ogrisel
Copy link

ogrisel commented Apr 20, 2022

This is making some scikit-learn tests fail, e.g. in sklearn/experimental/tests/test_enable_iterative_imputer.py the test_imports_strategies test fails because it expects nothing on stdout and stderr but gets:

gc_get_refs(gc): -1
gc_get_refs(gc): -1
gc_get_refs(gc): -1

from https://github.com/colesbury/nogil/blob/nogil/Modules/gcmodule.c#L757

Maybe this is revealing a real bug?

@colesbury
Copy link
Owner

Yes, I think it's a real bug. I'll look into it.

@colesbury
Copy link
Owner

This should be fixed now in 87c61c3

@ogrisel
Copy link
Author

ogrisel commented Apr 20, 2022

I confirm that this fixes the failing test.

All scikit-learn tests now pass! 🍾

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants