Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some jwt authentication fixes #51

Merged
merged 2 commits into from
Oct 26, 2020
Merged

Conversation

AMecea
Copy link
Member

@AMecea AMecea commented Oct 26, 2020

  • Restrict JWT algorithm when verifying to HS256
  • Use identity_field from account when building the token instead of id (str(account) == id)

@ccrisan
Copy link
Member

ccrisan commented Oct 26, 2020

Most certainly some potentially pain-inducing oversights :) Thanks!

@ccrisan ccrisan merged commit b7aa0e7 into colibris-framework:master Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants