Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bootstrap 5 Example #21

Merged
merged 2 commits into from
May 27, 2021
Merged

Add Bootstrap 5 Example #21

merged 2 commits into from
May 27, 2021

Conversation

coliff
Copy link
Owner

@coliff coliff commented May 27, 2021

Fixes: #3

@coliff coliff self-assigned this May 27, 2021
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

@@ -28,7 +29,7 @@ A show password as text toggle for Bootstrap forms

```html
<div class="input-group">
<input type="password" id="password" class="form-control rounded-right" required>
<input type="password" id="password" class="form-control rounded" required>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.

@coliff coliff merged commit b61546f into master May 27, 2021
@coliff coliff deleted the bootstrap5-example branch May 27, 2021 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Bootstrap 5 tests/examples/docs
1 participant