Fix requiring generic parameters to implement Default #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the builder uses #[derive(Default)], which adds additional bounds to the type parameters requiring them to implement Default. This is not required since the fields are all either `Option` or `PhantomData`, which always have defaults, and means that Builders cannot be instantiated for non-Default generics. This commit makes the builder implement Default manually, whithout any additional bounds.
TedDriggs
reviewed
Jan 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the builder uses #[derive(Default)], which adds additional bounds to the type parameters
requiring them to implement Default. This is not required since the fields are all either
Optionor
PhantomData, which always have defaults, and means that Builders cannot be instantiated fornon-Default generics.
This commit makes the builder implement Default manually, without any additional bounds.