Add #[builder(crate = "...")] for re-export scenarios #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TedDriggs
force-pushed
the
crate-field
branch
from
fa88b8a
to
1c69e68
Compare
TedDriggs
force-pushed
the
crate-field
branch
from
a4d6c38
to
1c69e68
Compare
|
The compiletest error here is legitimate; we seem to have lost a span on the custom error in this change, and I'm not sure where yet. That needs to be addressed before this can be merged. |
TedDriggs
commented
Nov 22, 2022
This allows setting the crate root for re-export scenarios. All hardcoded usage of `::derive_builder` in generated code has now been replaced by a `crate_root` variable, which contains the path to use. For backwards compatibility, this defaults to `::derive_builder`. Fixes #274
This should cause failures for any hardcoded usage of ::derive_builder
TedDriggs
force-pushed
the
crate-field
branch
from
1c69e68
to
44b0226
Compare
|
@ryo33 can you test this out using a git dependency and let me know how it goes? |
|
@TedDriggs All worked well. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch adds a new struct-level field which overrides the default crate path. This enables crates to re-export
derive_builder::Builderand avoid any direct dependency onderive_builderin their downstreams.Fixes #274