-
-
Notifications
You must be signed in to change notification settings - Fork 1
Status line for /censored missing description #1
Comments
Looks like Sinatra can't take a description for statuses: https://github.com/sinatra/sinatra/blob/5beba647310829acc89ff45137343507c74002fc/lib/sinatra/base.rb#L230 I can't seem to find anywhere in Sinatra that it'll provide the correct description for any status code. It must come from another library. |
Looks like this needs to be set in Rack: https://github.com/rack/rack/blob/96ae9b9fed8d6809383b6f48a5884437e76f8ca4/lib/rack/utils.rb#L506 |
And the list there is pulled from IANA: https://www.iana.org/assignments/http-status-codes/http-status-codes-1.csv So when |
Filed upstream in Rack as rack/rack#987. |
Turns out there was a PR already opened... just before I opened my issue. |
Upstream Rack has been fixed, I'll give them a day or two to do a release before I put on my cowboy hat and use the gem from git master. |
I decided to just try it, but I'm in version hell. Rack's master version has been bumped outside of what Sinatra master branch's lock to |
Reported by https://twitter.com/stderrdk/status/679026534049554432
The text was updated successfully, but these errors were encountered: