Skip to content
This repository has been archived by the owner on Apr 24, 2019. It is now read-only.

Status line for /censored missing description #1

Closed
colindean opened this issue Dec 21, 2015 · 7 comments
Closed

Status line for /censored missing description #1

colindean opened this issue Dec 21, 2015 · 7 comments
Labels

Comments

@colindean
Copy link
Owner

Reported by https://twitter.com/stderrdk/status/679026534049554432

@colindean colindean added the bug label Dec 21, 2015
@colindean
Copy link
Owner Author

Looks like Sinatra can't take a description for statuses: https://github.com/sinatra/sinatra/blob/5beba647310829acc89ff45137343507c74002fc/lib/sinatra/base.rb#L230

I can't seem to find anywhere in Sinatra that it'll provide the correct description for any status code. It must come from another library.

@colindean
Copy link
Owner Author

@colindean
Copy link
Owner Author

And the list there is pulled from IANA:

https://www.iana.org/assignments/http-status-codes/http-status-codes-1.csv

So when curl https://www.iana.org/assignments/http-status-codes/http-status-codes-1.csv | grep 451 has content, Rack can be updated and all the updates cascade down.

@colindean
Copy link
Owner Author

Filed upstream in Rack as rack/rack#987.

@colindean
Copy link
Owner Author

Turns out there was a PR already opened... just before I opened my issue.

rack/rack/pull/985

@colindean
Copy link
Owner Author

Upstream Rack has been fixed, I'll give them a day or two to do a release before I put on my cowboy hat and use the gem from git master.

@colindean
Copy link
Owner Author

I decided to just try it, but I'm in version hell. Rack's master version has been bumped outside of what Sinatra master branch's lock to ~> 1.6 will allow. Looks like I need to wait until Sinatra is bumped for Rack 2.0.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant