Add support for HTTP 451 "Unavailable for Legal Reasons" #985
Conversation
| @@ -128,6 +128,7 @@ def not_found?; status == 404; end | |||
| def method_not_allowed?; status == 405; end | |||
| def precondition_failed?; status == 412; end | |||
| def unprocessable?; status == 422; end | |||
| def unavailable?; status == 451; end | |||
There was a problem hiding this comment.
This could be confusing with 503 Service Unavailable. I'd be open to renaming this method to unavailable_for_legal_reasons, but that's awfully wordy. Figured I'd start simple.
There was a problem hiding this comment.
We don't have shorthand methods for every status code. Think this is one we'd omit.
There was a problem hiding this comment.
Omitting is probably OK. I imagine use of it would be sufficiently rare that the code could be checked directly.
However, for completion, it might be a good idea to keep it. Maybe call it legally_unavailable? or unavailable_legally? or unavailable_by_law? or censored? or censored_by_law?
There was a problem hiding this comment.
@jeremy, @colindean: 👌 I removed the method in 040de0d.
There was a problem hiding this comment.
👍 Please rebase + squash to a single commit as well.
| @@ -551,6 +551,7 @@ def names | |||
| 428 => 'Precondition Required', | |||
| 429 => 'Too Many Requests', | |||
| 431 => 'Request Header Fields Too Large', | |||
| 451 => 'Unavailable For Legal Reasons', | |||
There was a problem hiding this comment.
Would it be wise to put a comment on here stating that the code isn't yet present on the IANA list as of the current date, in the unlikely event that someone tries to import from the CSV linked in the comment on line 503?
There was a problem hiding this comment.
Would it be wise to put a comment on here
Seems like a stylistic thing. I'm fine either way, and will defer to @jeremy.
There was a problem hiding this comment.
Would be appropriate to mention the exception at #985 (diff) since the comment says exactly how this list is generated.
ktheory
force-pushed
the
http-451-unavailable-for-legal-reasons
branch
2 times, most recently
from
65ca111
to
c97173f
Compare
|
All squashed & rebased & updated per the IANA CSV of status codes. 😌 |
Adds support for the newly approved HTTP 451 response code, “Unavailable for Legal Reasons”. IETF draft specification: https://tools.ietf.org/html/draft-tbray-http-legally-restricted-status-0 5 More info: http://www.451unavailable.org
ktheory
force-pushed
the
http-451-unavailable-for-legal-reasons
branch
from
c97173f
to
73e0827
Compare
…easons Add support for HTTP 451 "Unavailable for Legal Reasons"
|
🍻 |
Adds support for the newly approved HTTP 451 response code,
“Unavailable for Legal Reasons”.
Adds
Rack::Response#unavailable?method.See also: