Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix firebase import #3

Closed
dustinmyers opened this issue Nov 13, 2020 · 1 comment
Closed

Fix firebase import #3

dustinmyers opened this issue Nov 13, 2020 · 1 comment

Comments

@dustinmyers
Copy link

In firebaseClient, you are importing the firebaseClient like this: import * as firebasClient from 'firebase/app'.

A breaking change has been pushed in the way firebase SDK v8.0.0 handles exports.

For anyone coming to your repo and tutorial, when they download firebase now, this breaks.

The syntax now is import firebaseClient from 'firebase/app'.

Here's the SO question for reference - https://stackoverflow.com/questions/64545862/upgrade-to-firebase-js-8-0-0-attempted-import-error-app-is-not-exported-from
@colinhacks
Copy link
Owner

Good to know. I just upgraded all the dependencies and fixed this issue. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@colinhacks @dustinmyers