Fix transform ctx.addIssue to work with parseAsync

colinhacks · May 11, 2022 · b36cf43 · b36cf43
1 parent cb2b86c
commit b36cf43
Show file tree

Hide file tree

Showing 4 changed files with 68 additions and 4 deletions.
diff --git a/deno/lib/__tests__/transformer.test.ts b/deno/lib/__tests__/transformer.test.ts
@@ -11,7 +11,7 @@ const stringToNumber = z.string().transform((arg) => parseFloat(arg));
 //   .transform((n) => String(n));
 const asyncNumberToString = z.number().transform(async (n) => String(n));
 
-test("transform ctx.addIssue", () => {
+test("transform ctx.addIssue with parse", () => {
   const strs = ["foo", "bar"];
 
   expect(() => {
@@ -42,6 +42,38 @@ test("transform ctx.addIssue", () => {
   );
 });
 
+test("transform ctx.addIssue with parseAsync", async () => {
+  const strs = ["foo", "bar"];
+
+  const result = await z
+    .string()
+    .transform((data, ctx) => {
+      const i = strs.indexOf(data);
+      if (i === -1) {
+        ctx.addIssue({
+          code: "custom",
+          message: `${data} is not one of our allowed strings`,
+        });
+      }
+      return data.length;
+    })
+    .safeParseAsync("asdf");
+
+  expect(JSON.parse(JSON.stringify(result))).toEqual({
+    success: false,
+    error: {
+      issues: [
+        {
+          code: "custom",
+          message: "asdf is not one of our allowed strings",
+          path: [],
+        },
+      ],
+      name: "ZodError",
+    },
+  });
+});
+
 test("basic transformations", () => {
   const r1 = z
     .string()

diff --git a/deno/lib/types.ts b/deno/lib/types.ts
@@ -3328,7 +3328,7 @@ export class ZodEffects<
             //   return { status: "dirty", value: base.value };
             // }
             return Promise.resolve(effect.transform(base.value, checkCtx)).then(
-              OK
+              (result) => ({ status: status.value, value: result })
             );
           });
       }

diff --git a/src/__tests__/transformer.test.ts b/src/__tests__/transformer.test.ts
@@ -10,7 +10,7 @@ const stringToNumber = z.string().transform((arg) => parseFloat(arg));
 //   .transform((n) => String(n));
 const asyncNumberToString = z.number().transform(async (n) => String(n));
 
-test("transform ctx.addIssue", () => {
+test("transform ctx.addIssue with parse", () => {
   const strs = ["foo", "bar"];
 
   expect(() => {
@@ -41,6 +41,38 @@ test("transform ctx.addIssue", () => {
   );
 });
 
+test("transform ctx.addIssue with parseAsync", async () => {
+  const strs = ["foo", "bar"];
+
+  const result = await z
+    .string()
+    .transform((data, ctx) => {
+      const i = strs.indexOf(data);
+      if (i === -1) {
+        ctx.addIssue({
+          code: "custom",
+          message: `${data} is not one of our allowed strings`,
+        });
+      }
+      return data.length;
+    })
+    .safeParseAsync("asdf");
+
+  expect(JSON.parse(JSON.stringify(result))).toEqual({
+    success: false,
+    error: {
+      issues: [
+        {
+          code: "custom",
+          message: "asdf is not one of our allowed strings",
+          path: [],
+        },
+      ],
+      name: "ZodError",
+    },
+  });
+});
+
 test("basic transformations", () => {
   const r1 = z
     .string()

diff --git a/src/types.ts b/src/types.ts
@@ -3328,7 +3328,7 @@ export class ZodEffects<
             //   return { status: "dirty", value: base.value };
             // }
             return Promise.resolve(effect.transform(base.value, checkCtx)).then(
-              OK
+              (result) => ({ status: status.value, value: result })
             );
           });
       }