Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeouts are not configurable for RPC #76

Closed
peay opened this issue Apr 12, 2017 · 5 comments
Closed

Timeouts are not configurable for RPC #76

peay opened this issue Apr 12, 2017 · 5 comments

Comments

@peay
Copy link

peay commented Apr 12, 2017

The timeouts for RPC do not seem to be configurable. From rpc.go:

var (
	connectTimeout  = 1 * time.Second
	namenodeTimeout = 3 * time.Second
	datanodeTimeout = 3 * time.Second
)

These values are rather low (especially the connection timeout), and I have been experiencing quite a lot of timeouts.

Being able to configure these would be very helpful. This does not have to be per client -- a global setting would be fine too.

@peay peay changed the title Timeouts are not configuration Timeouts are not configurable for RPC Apr 12, 2017
@colinmarc
Copy link
Owner

Hi @peay,

Good point - this should definitely be configurable. This dovetails well with the need for a configurable dialer in #70.

@colinmarc
Copy link
Owner

With #77, there now exists a ClientOptions struct, so this should now be implementable.

@Itfly
Copy link

Itfly commented Jul 18, 2018

@colinmarc Any update for this issue, i also got error: dial tcp: i/o timeout. After modifying the value to 3, the real error is hostname cannot be resolved. This is beacause the datanodes' hostnames are not being registed into my company's DNS server.

@colinmarc
Copy link
Owner

I'm working on a rework of timeouts. But it doesn't sound like your issue is timouts, @Itfly; it sounds like your datanode hosts aren't resolvable from the client. If you fix your DNS setup it should work.

@Itfly
Copy link

Itfly commented Jul 27, 2018

@colinmarc Yes it works after i adding the datanode host to our company's DNSSelfService. However, i suggest to make it configurable about using hostname or ip address (#123)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants