Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix permissions for Mkdir call in get.go #9

Closed
maugen opened this issue Feb 24, 2015 · 3 comments
Closed

Fix permissions for Mkdir call in get.go #9

maugen opened this issue Feb 24, 2015 · 3 comments

Comments

@maugen
Copy link

maugen commented Feb 24, 2015

Directories are currently created with a mode which makes them unusable:

cmd/hdfs/get.go: err = os.Mkdir(fullDest, 0644)

This results in drw-r--r-- perms, which are good for basically nothing :)

Please update to 0755, or better yet base it on umask setting.

Cheers!

  • adam
@colinmarc
Copy link
Owner

Hey Adam, thanks for the report!

I think you may have an old version - we set it to 0755 now: https://github.com/colinmarc/hdfs/blob/master/cmd/hdfs/mkdir.go#L27

Please let me know if I'm misunderstanding, and thanks again!

@colinmarc
Copy link
Owner

Wait, actually, I totally did misunderstand your report! Sorry about that. I'll fix this shortly.

@colinmarc colinmarc reopened this Feb 25, 2015
@maugen
Copy link
Author

maugen commented Feb 25, 2015

Shortly was an understatement ;)

Thanks a lot for this fix!

  • adam

On Tuesday, February 24, 2015, Colin Marc notifications@github.com wrote:

Closed #9 #9 via 7306883
7306883
.


Reply to this email directly or view it on GitHub
#9 (comment).

guangie88 pushed a commit to guangie88/hdfs that referenced this issue Jan 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants