support for ls -R (issue #100) #289
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @gardenia, thanks for this contribution (and for the other ones)!! Do you mind adding some tests to lock in the behavior? |
|
Hi @colinmarc , Yes fair point. I had written this patch before the others so hadn't grocked how the tests worked until I'd written the other patches. I'll update this patch with some tests soon. Thanks |
gardenia
force-pushed
the
recursive_ls
branch
from
60fb79b
to
5e53832
Compare
|
Hi @colinmarc , I have updated the pull request with a few tests. Thanks. |
colinmarc
force-pushed
the
recursive_ls
branch
4 times, most recently
from
03dbcde
to
0ae21cd
Compare
Fixes colinmarc#100.
|
I'm sorry this sat on the shelf for so long! I ended up tweaking it significantly and merging as be7d224. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.