Add globbing support #38
Conversation
|
Hi! is there any reason |
|
Hi! I guess I didn't think about using it just because I'm comparing 2 strings not paths. But path.Match does make more sense in the way it handles globs. |
|
I actually started using this today and as the go |
| @@ -41,6 +41,11 @@ func New(address string) (*Client, error) { | |||
| return NewForUser(address, username) | |||
| } | |||
|
|
|||
| // Return a New Client with auto config | |||
| func AutoConfigClient() (*Client, error) { | |||
There was a problem hiding this comment.
Rather than a new method, let's just have this be default fallback behavior for New if an empty string is passed for the namenode.
|
Regarding globs: I don't really see the benefit to including globs in the library, since the command line client already supports them and they're really a bash thing. I'd cite that there's no equivalent method in the go I'm interested in this config loading stuff, though! Thanks so much for being willing to contribute, it really makes my day whenever there's a PR on this project. |
| Port int | ||
| } | ||
|
|
||
| type nameNodeError struct { |
There was a problem hiding this comment.
There's no need for this to be a struct. it can just be var ErrUnresolvedNamenode = errors.New("Couldn't find a namenode address in any config.")
This is loosely based on the snakebite glob support.