Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a proxy feature for images uploaded before installation of the adapter #10

Closed
GerardVivancos opened this issue Mar 7, 2017 · 2 comments

Comments

@GerardVivancos
Copy link
Contributor

When the adapter is installed it works flawlessly for newly uploaded images but, of course, it does not work for pre-existing ones.

These are usually linked using relative URLs. Because of this, by using the serve() method, they can be served from S3 by proxying them from the bucket, provided they are copied there, without needing to edit every link on previously published posts.

We've got a PR ready for this.

@colinmeinke
Copy link
Owner

Sounds good!

GerardVivancos added a commit to GerardVivancos/ghost-storage-adapter-s3 that referenced this issue Mar 7, 2017
Image URLs relative to the host are proxyed to S3 and, if they exist, returned to the user.

colinmeinke#10
@colinmeinke
Copy link
Owner

Released. Thanks @GerardVivancos, nice work 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants