New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keccak: Function expects 2 parameters but 1 was given #5

Closed

critesjosh opened this issue Jul 21, 2023 · 0 comments · Fixed by #6

Contributor

critesjosh commented Jul 21, 2023 •

edited

Loading

This is using Noir version 0.8.0, i think the message_size parameter was introduced in version 0.7.1.

error: Function expects 2 parameters but 1 was given
   ┌─ /home/josh/nargo/github.com/colinnielsen/ecrecover-noirv0.5.0/src/secp256k1.nr:59:30
   │
59 │         let hashed_pub_key = std::hash::keccak256(pub_key);
   │                              -----------------------------

Keccak now takes two arguments, see the docs here.

The text was updated successfully, but these errors were encountered:

colinnielsen mentioned this issue

feat: optimize circuit + fix keccak impl #6

Merged

colinnielsen closed this as completed in #6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment