Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified the logic for validating scores #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

LuqiPan
Copy link

@LuqiPan LuqiPan commented Mar 17, 2016

Currently the logic doesn't account for deuce games, for example I just lost a game 15-17.

I think as long as we have the winner's score > 11 and loser's score at least 2 points less than winner's, we're good.

@colinpollock
Copy link
Owner

Hey, thanks for the pull request!

I think this will break the Elo scoring logic. There are two K values used: one for games to 11 and one for games to 21. In resource.py:GameListResource:post I checked whether the game was to 11 by checking whether winner_score == 11.

Currently you can enter deuce games as 11-10 or 21-20. This isn't explained well in the IRC bot's HELP.

So I think there are two potential ways forward:

  1. Make it clear how to enter deuce games currently.
  2. Update your branch to get whether the game is to 21 or 11 some other way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants