Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Anshul-13J's journey #153

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Anshul-13J
Copy link

Description

Added my details and journey on Github.

Fixes # (issue)

Checklist:

  • [ ✔️] My code follows the style guidelines of this project
  • [ ✔️] I have performed a self-review of my own code
  • [ ✔️] I have commented my code, particularly in hard-to-understand areas
  • [ ✔️] I have made corresponding changes to the documentation
  • [ ✔️] My changes generate no new warnings
  • [ ✔️] Any dependent changes have been merged and published in downstream modules

Copy link
Member

@Adarsh-jaiss Adarsh-jaiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Looks amazing! 😄

@Adarsh-jaiss Adarsh-jaiss added Hacktoberfest specially for hacktoberfest projects hacktoberfest-accepted labels Oct 3, 2022
@Adarsh-jaiss
Copy link
Member

Copy link
Member

@vikasganiga05 vikasganiga05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Anshul-13J , Please remove the package-lock.json file.
My suggestion is to write more about your journey on the markdown file.

@vikasganiga05
Copy link
Member

I resolved the merge conflict. When the package-lock.json file is removed it's ready for merge.

@Adarsh-jaiss
Copy link
Member

@vikasganiga05
Copy link
Member

Not sure, please look at the markdown file. I think there is something broken.

Copy link
Member

@vikasganiga05 vikasganiga05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Anshul-13J , Can you please write more about your journey? If you want to know what exactly your journey should include please refer to What should I share in my journey?.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest specially for hacktoberfest projects hacktoberfest-accepted size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants