Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modified Data.json with my details and added shrey11ansh journey #181

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shrey11ansh
Copy link

Added Shreyansh Chaubey's Journey

Copy link
Member

@vikasganiga05 vikasganiga05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I have suggested some changes to make the connect with me section look good.

Comment on lines +25 to +26
[Github]-https://github.com/shrey11ansh
[Instagram]-https://instagram.com/shrey_ansh.11?igshid=YmMyMTA2M2Y=
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[Github]-https://github.com/shrey11ansh
[Instagram]-https://instagram.com/shrey_ansh.11?igshid=YmMyMTA2M2Y=
:link: GitHub - @shrey11ansh ([https://github.com/shrey11ansh](https://github.com/shrey11ansh))
:link: Instagram - @shrey_ansh.11 ([https://instagram.com/shrey_ansh.11](https://instagram.com/shrey_ansh.11))

Copy link
Member

@vikasganiga05 vikasganiga05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, you may forgot to add your new entry to Data.json file.

Here is the format of a new entry 👇

{
  "name": "YOUR_NAME",
  "username": "YOUR_GITHUB_USERNAME",
  "avatar": "https://github.com/YOUR_GITHUB_USERNAME.png"
}

Please follow How to contribute or contribution guidelines for more info.

shailendra2003
shailendra2003 approved these changes Oct 11, 2022
@vikasganiga05
Copy link
Member

Hi @shrey11ansh , A friendly reminder. Please update the PR with suggested changes. Thank You.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest specially for hacktoberfest projects hacktoberfest-accepted size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants