Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formalizing Data.json with fewer parameters #179 #184

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

UlbertAO
Copy link

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # 179

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • [*] Test A manually tested if landing page loads as expected with image icons and when navigate to other pages favicon also changes
  • [*] Test B document correction in README.md

Checklist:

  • [*] My code follows the style guidelines of this project
  • [*] I have performed a self-review of my own code
  • [*] I have commented my code, particularly in hard-to-understand areas
  • [*] I have made corresponding changes to the documentation
  • [*] My changes generate no new warnings
  • [*] Any dependent changes have been merged and published in downstream modules

piece of code for Data.json

const fs=require("fs");
let d;
d=JSON.parse(fs.readFileSync("Data.json",'utf8'));
d=d.map(({name,username})=>({name,username}));
fs.writeFileSync("Data.json",JSON.stringify(d))

@vikasganiga05
Copy link
Member

Hi @UlbertAO , Thanks for contributing. But we added the avatar property for those who don't have github profile picture or the user want to use another profile picture as a avatar. This will break flow of the projects. What are your thoughts on this @Adarsh-jaiss ?

@UlbertAO
Copy link
Author

UlbertAO commented Oct 22, 2022

Hi @vikasganiga05 , @Adarsh-jaiss
If that is the case then can we do it like this
-if people want their avatar to be same as github profile avatar then they need to specify name and username only
-if people want some custom avatar then can add avatar url as well

NOTE: if avatar is not specified in data.json git hub profile avatar will be picked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants