Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added My Journey #190

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

yash-raj10
Copy link

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@Adarsh-jaiss
Copy link
Member

  • please update your information in data.json file as well, so that your profile is visible on the website!

@Adarsh-jaiss Adarsh-jaiss self-requested a review October 18, 2022 13:14
@Adarsh-jaiss Adarsh-jaiss added Hacktoberfest specially for hacktoberfest projects hacktoberfest-accepted labels Oct 18, 2022
Copy link
Member

@vikasganiga05 vikasganiga05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix these typos and grammar mistakes.

Comment on lines +4 to +7
- hlo , my name is Yash raj.
- i wiil be joining my collage this year
- i am currently learing DSA and CSS & knows JAVA,HTML
a little bit of Python Till now.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- hlo , my name is Yash raj.
- i wiil be joining my collage this year
- i am currently learing DSA and CSS & knows JAVA,HTML
a little bit of Python Till now.
- Hello, my name is Yash raj.
- I will be joining my college this year
- I am currently learning DSA and CSS & know JAVA, HTML
a little bit of Python Till now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest specially for hacktoberfest projects hacktoberfest-accepted size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants