update tests

collab-project · Aug 2, 2018 · 67f8c61 · 67f8c61
1 parent a9ecf4a
commit 67f8c61
Show file tree

Hide file tree

Showing 5 changed files with 18 additions and 23 deletions.
diff --git a/test/controls/camera-button.spec.js b/test/controls/camera-button.spec.js
@@ -31,13 +31,13 @@ describe('controls.CameraButton', function() {
 
         expect(button.el().nodeName).toEqual('BUTTON');
         expect(button.on).toBeFunction();
-        expect(button.enabled_).toEqual(true);
+        expect(button.enabled_).toBeTrue()
         expect(button.controlText_).toEqual('Image');
 
         let styleClasses = ['vjs-camera-button', 'vjs-control', 'vjs-button',
             'vjs-icon-photo-camera'];
         styleClasses.forEach((e) => {
-            expect(button.hasClass(e)).toEqual(true);
+            expect(button.hasClass(e)).toBeTrue();
         });
     });
 
@@ -50,11 +50,11 @@ describe('controls.CameraButton', function() {
     it('changes appearance when startRecord or stopRecord is triggered', function(done) {
         let button = new CameraButton(player);
 
-        expect(button.hasClass('vjs-icon-photo-camera')).toEqual(true);
+        expect(button.hasClass('vjs-icon-photo-camera')).toBeTrue();
 
         player.one('startRecord', function() {
-            expect(button.hasClass('vjs-icon-photo-camera')).toEqual(false);
-            expect(button.hasClass('vjs-icon-replay')).toEqual(true);
+            expect(button.hasClass('vjs-icon-photo-camera')).toBeFalse();
+            expect(button.hasClass('vjs-icon-replay')).toBeTrue();
             expect(button.controlText_).toEqual('Retry');
 
             setTimeout(function() {
@@ -65,8 +65,8 @@ describe('controls.CameraButton', function() {
             }, 2000);
         });
         player.one('stopRecord', function() {
-            expect(button.hasClass('vjs-icon-replay')).toEqual(false);
-            expect(button.hasClass('vjs-icon-photo-camera')).toEqual(true);
+            expect(button.hasClass('vjs-icon-replay')).toBeFalse();
+            expect(button.hasClass('vjs-icon-photo-camera')).toBeTrue();
             expect(button.controlText_).toEqual('Image');
 
             done();

diff --git a/test/controls/device-button.spec.js b/test/controls/device-button.spec.js
@@ -25,7 +25,7 @@ describe('controls.DeviceButton', function() {
 
         expect(button.el().nodeName).toEqual('BUTTON');
         expect(button.on).toBeFunction();
-        expect(button.enabled_).toEqual(true);
+        expect(button.enabled_).toBeTrue();
         expect(button.controlText_).toEqual('Device');
     });
 

diff --git a/test/controls/record-toggle.spec.js b/test/controls/record-toggle.spec.js
@@ -25,13 +25,13 @@ describe('controls.RecordToggle', function() {
 
         expect(toggle.el().nodeName).toEqual('BUTTON');
         expect(toggle.on).toBeFunction();
-        expect(toggle.enabled_).toEqual(true);
+        expect(toggle.enabled_).toBeTrue();
         expect(toggle.controlText_).toEqual('Record');
 
         let styleClasses = ['vjs-record-button', 'vjs-control', 'vjs-button',
             'vjs-icon-record-start'];
         styleClasses.forEach((e) => {
-            expect(toggle.hasClass(e)).toEqual(true);
+            expect(toggle.hasClass(e)).toBeTrue();
         });
     });
 
@@ -40,7 +40,7 @@ describe('controls.RecordToggle', function() {
 
         player.one('ready', function() {
             toggle.disable();
-            expect(toggle.enabled_).toEqual(false);
+            expect(toggle.enabled_).toBeFalse();
 
             done();
         });
@@ -49,19 +49,19 @@ describe('controls.RecordToggle', function() {
     it('change appearance when startRecord or stopRecord is triggered', function(done) {
         let toggle = new RecordToggle(player);
 
-        expect(toggle.hasClass('vjs-icon-record-start')).toEqual(true);
+        expect(toggle.hasClass('vjs-icon-record-start')).toBeTrue();
 
         player.one('ready', function() {
             player.trigger('startRecord');
 
-            expect(toggle.hasClass('vjs-icon-record-start')).toEqual(false);
-            expect(toggle.hasClass('vjs-icon-record-stop')).toEqual(true);
+            expect(toggle.hasClass('vjs-icon-record-start')).toBeFalse();
+            expect(toggle.hasClass('vjs-icon-record-stop')).toBeTrue();
             expect(toggle.controlText_).toEqual('Stop');
 
             player.trigger('stopRecord');
 
-            expect(toggle.hasClass('vjs-icon-record-stop')).toEqual(false);
-            expect(toggle.hasClass('vjs-icon-record-start')).toEqual(true);
+            expect(toggle.hasClass('vjs-icon-record-stop')).toBeFalse();
+            expect(toggle.hasClass('vjs-icon-record-start')).toBeTrue();
             expect(toggle.controlText_).toEqual('Record');
 
             done();
@@ -74,7 +74,7 @@ describe('controls.RecordToggle', function() {
         player.one('deviceReady', function() {
             // start
             toggle.trigger('click');
-            expect(player.record().isRecording()).toEqual(true);
+            expect(player.record().isRecording()).toBeTrue();
 
             done();
         });

diff --git a/test/utils/detect-browser.spec.js b/test/utils/detect-browser.spec.js
@@ -54,7 +54,7 @@ describe('utils.detect-browser', function() {
     it('detects Opera browser', function() {
         let isOpera = detectBrowser.isOpera();
 
-        expect(isOpera).toEqual(false);
+        expect(isOpera).toBeFalse();
     });
 
     /** @test {detectBrowser} */

diff --git a/test/videojs.record.spec.js b/test/videojs.record.spec.js
@@ -3,7 +3,6 @@
  */
 
 import TestHelpers from './test-helpers.js';
-import * as detectBrowser from '../src/js/utils/detect-browser.js';
 
 // registers the plugin
 import Record from '../src/js/videojs.record.js';
@@ -153,10 +152,6 @@ describe('Record', function() {
 
         player.one('finishRecord', function() {
             let data = player.recordedData;
-            if (detectBrowser.isChrome()) {
-                // got an object with a video property containing a blob
-                data = player.recordedData.video;
-            }
             expect(data instanceof Blob).toBeTruthy();
 
             // wait till it's loaded before destroying