-
-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
videojs 5.0 support #6
Comments
Hi @Billybobbonnet, thanks for your feedback. I think it makes sense to support v5 as soon as they make a stable release. We could look into a port before that and maybe work on a separate branch until then. Once it's released we can move v4 to a stable branch and put v5 implementation on the master/trunk. So yea, feel free to poke at it, PRs are always welcome. |
Ok. I'll keep in touch. Thanks for your fast answer. |
I looked a bit more into it. Here are some info on the task:
var VjsButton = videojs.getComponent('Button');
var MyNewButton = videojs.extends(VjsButton, {
constructor: function() {
VjsButton.call(this, player, options);
}, // notice the comma
otherFunc: function() {
// do something
}
});
I gave it a few tries, and failed. I don't know if I did it wrong or if it is too early to try it. So I will not dive in this yet because I don't feel confident enough in my chances to achieve it in a reasonable time and I must prioritize other topics. I will probably come back on this in one month or two. |
Also note that https://github.com/collab-project/videojs-wavesurfer is an optional dependency for videojs-record that also needs to be ported at some point. |
Looks like video.js 5.0 is ready: videojs/video.js@8724598 |
Before porting videojs-record I want to port videojs-wavesurfer because videojs-record depends on it in audio mode. See collab-project/videojs-wavesurfer#5. |
I heavily modified videojs-record to suit my needs. I work on a video analysis tool. I skipped the webRTC part and merged it with a custom version of the videojs plugin rangeslider". To make it short, the plugin "records" a sub-part of the video (rangeslider displays the "chunk") and allow pseudo video editing. For this project, I also have modified and included several other plugins (hotkeys, hd source switch, etc.). This is then a big (huge?) work to update the whole stuff to v5.0, not to mention that I am not confident about my success chances 😆 Concerning videojs-wavesurfer, I plan to use it too but didn't put efforts into its integration so far (pre 5.0). I would welcome any help to port it but I cannot undertake the porting by myself in my situation. Also, I can send you by email the modified code of your plugin if you want me to. I wish I could make a PR or publish it as a different plugin but I am a little overworked at the moment. It still could be an option in the upcoming months since I plan to publish my code as open-source. |
videojs-wavesurfer basically is ready and ported to v5, only need to merge it to master. It was not a lot of work and I think porting videojs-record won't be a problem either. |
Well, the port to video.js 5 is ready for testing (@Billybobbonnet ?): https://github.com/collab-project/videojs-record/archive/videojs5.zip |
Great news! I will take a look at it this weekend. Congrats for the port :) 2015-10-14 17:21 GMT+02:00 Thijs Triemstra notifications@github.com:
|
I have partially updated my player, including your plugin in a modified version. I still have to add wavesurfer but everything works great so far. Good job on the port. |
Sounds exciting man :) Looking forward to a PR..! |
I want to switch to 5.0 but I am struggling with their new plug-in management. I will work on it but concerning this plugin, I wanted to check first if you plan to migrate to 5.0. If I manage to do it, do you want a PR?.
The text was updated successfully, but these errors were encountered: