Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create custom parser #46

Closed
Razaloc opened this issue Nov 9, 2022 · 0 comments · Fixed by #41
Closed

Create custom parser #46

Razaloc opened this issue Nov 9, 2022 · 0 comments · Fixed by #41
Labels
enhancement New feature or request

Comments

@Razaloc
Copy link
Contributor

Razaloc commented Nov 9, 2022

The command copy takes two arguments, but the first one can be a PathBuf or a reqwest::Url, depending of the kind of copy source; local or remote. The parser should try to convert the first argument into a Url and if it fails into a PathBuf, then store it into an enumerate.
The parser also needs to handle the first argument of copy and possibility of future different arguments.
Razaloc added a commit that referenced this issue Nov 10, 2022
@Razaloc
Custom parser function
2204e4d 
To handle the possibility of the image route been a path or a url
the new parser uses an enum Image to keep that information and avoid
repeated type parsing.
Closes: #46

Signed-off-by: Rafael Garcia Ruiz <rafael.garcia@collabora.com>
@Razaloc Razaloc mentioned this issue Nov 10, 2022
Closed
Razaloc added a commit that referenced this issue Nov 10, 2022
@Razaloc
Custom parser function
77bf33f 
To handle the possibility of the image route been a path or a url
the new parser uses an enum Image to keep that information and avoid
repeated type parsing.
Closes: #46

Signed-off-by: Rafael Garcia Ruiz <rafael.garcia@collabora.com>
@Razaloc Razaloc added the enhancement New feature or request label Nov 10, 2022
@Razaloc Razaloc mentioned this issue Nov 12, 2022
Merged
@bors bors bot closed this as completed in a588fa7 Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
1 participant
@Razaloc