Fix including excluded repositories due to broken status #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
your dependency has been merged now :) |
refi64
force-pushed
the
wip/refi64/broken-excluded
branch
from
2c6ba04
to
037cde5
Compare
sjoerdsimons
reviewed
Apr 6, 2023
sjoerdsimons
reviewed
Apr 6, 2023
sjoerdsimons
reviewed
Apr 6, 2023
refi64
force-pushed
the
wip/refi64/broken-excluded
branch
2 times, most recently
from
3d13510
to
d92b209
Compare
There's a short period of time after a package is uploaded that OBS might report it as `broken`, with the details set to `empty`. This means that, when the build metadata is gathered, excluded architectures end up being *included*, because the status is `broken` instead of `excluded`. In order to work around this, wait for a short period of time if the package's status is `broken` and details are `empty`, that way we can actually check if the architecture is excluded. Signed-off-by: Ryan Gonzalez <ryan.gonzalez@collabora.com>
refi64
force-pushed
the
wip/refi64/broken-excluded
branch
from
d92b209
to
1c7e0d4
Compare
sjoerdsimons
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a short period of time after a package is uploaded that OBS might report it as
broken, with the details set toempty. This means that, when the build metadata is gathered, excluded architectures end up being included, because the status isbrokeninstead ofexcluded.In order to work around this, wait for a short period of time if the package's status is
brokenand details areempty, that way we can actually check if the architecture is excluded.Signed-off-by: Ryan Gonzalez ryan.gonzalez@collabora.com
In draft status because it depends on collabora/open-build-service-rs#10.