Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce WOPI endpoints for local file access #110

Closed
kendy opened this issue Oct 2, 2020 · 1 comment
Closed

Introduce WOPI endpoints for local file access #110

kendy opened this issue Oct 2, 2020 · 1 comment

Comments

@kendy
Copy link
Contributor

kendy commented Oct 2, 2020

This is an Easy Hack.
Potential mentors: @kendy

When the Collabora Online is built with --enable-debug, it is possible to open local files for easy testing. The problem with the current implementation is that it is a separate code path from what is later used in the real world - which always integrates through WOPI.

This task has two parts:

  1. Introduce serving the local files via WOPI endpoints directly from loolwsd.
  2. Kill the implementation of the local file storage, and do appropriate changes in the loolwsd.xml setting.

Ad 1) - this can be done in wsd/FileServer.cpp, see the FileServerRequestHandler::handleRequest - which would implement the GET and POST methods appropriately. For an inspiration what endpoints have to be implemented, have a look at test/WopiTestServer.hpp, method handleHttpRequest() that does the same thing for unit tests.

Ad 2) - git grep LocalStorage and kill all the uses. Then update the message that outputs the URL to be issued locally with the right one (git grep LOOLWSD_TEST_DOCUMENT_RELATIVE_PATH) and also check the setting in loolwsd.xml.in (the filesystem option).

@pedropintosilva
Copy link
Contributor

fixed by #3226

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants