better user feedback

Change-Id: Ife9b6b936f33570c56e7aedc590cb8d6f5f9bde4
collectd · Jun 19, 2019 · 3ea62de · 3ea62de
1 parent 742f1db
commit 3ea62de
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/daemon/configfile.c b/src/daemon/configfile.c
@@ -413,9 +413,10 @@ static int dispatch_block_plugin(oconfig_item_t *ci) {
   /* Hm, no complex plugin found. Dispatch the values one by one */
   for (int i = 0, ret = 0; i < ci->children_num; i++) {
     if (ci->children[i].children == NULL) {
-      ret = dispatch_value_plugin(name, ci->children + i);
+      oconfig_item_t *child = ci -> children + i;
+      ret = dispatch_value_plugin(name, child);
       if (ret != 0) {
-        ERROR("dispatch for plugin %s returned non-zero code : %i", name, ret);
+        ERROR("Plugin %s failed to handle option %s, return code: %i", name, child -> key, ret);
         return ret;
       }
     } else {

diff --git a/src/logfile.c b/src/logfile.c
@@ -52,7 +52,7 @@ static int logfile_config(const char *key, const char *value) {
     log_level = parse_log_severity(value);
     if (log_level < 0) {
       log_level = LOG_INFO;
-      ERROR("logfile: invalid loglevel [%s] defaulting to 'info'", value);
+      WARNING("logfile: invalid loglevel [%s] defaulting to 'info'", value);
       return 0;
     }
   } else if (0 == strcasecmp(key, "File")) {