Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write_graphite: remove linking against libyajl #1976

Merged
merged 1 commit into from
Oct 4, 2016

Conversation

mfournier
Copy link

write_graphite doesn't have anything to do with json. This seems to have
been accidentally added in 30c1111.

Fixes https://bugs.debian.org/839771

write_graphite doesn't have anything to do with json. This seems to have
been accidentally added in 30c1111.

Fixes https://bugs.debian.org/839771
@mfournier mfournier added Bug A genuine bug build An issue with the build labels Oct 4, 2016
@mfournier mfournier added this to the 5.6 milestone Oct 4, 2016
@mfournier
Copy link
Author

FWIW, with this patch we get:

$ /opt/collectd/sbin/collectd  -T
option = ReadThreads; value = -1;
Created new plugin context.
plugin_load: plugin "cpu" successfully loaded.
plugin_load: plugin "write_graphite" successfully loaded.
Done parsing `/opt/collectd/share/collectd/types.db'
interval_g = 10.000;
timeout_g = 2;
hostname_g = lonquimay.wrk.lsn.camptocamp.com;
Exiting normally.
collectd: Stopping 5 write threads.
plugin: stop_write_threads: Signalling `write_cond'
write_graphite plugin: Connecting to localhost:2003 via tcp failed. The last error was: failed to connect to remote host: Connection refused
write_graphite plugin: wg_flush_nolock: timeout = 0.000; send_buf_fill = 0;
$ ldd /opt/collectd/lib/collectd/write_graphite.so 
        linux-vdso.so.1 (0x00007ffd3252e000)
        libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007f216c469000)
        /lib64/ld-linux-x86-64.so.2 (0x00005572c0416000)

@octo
Copy link
Member

octo commented Oct 4, 2016

LGTM

The write_graphite plugin was building with utils_format_json.c for a long time, though. It appears that was added in 2f6cab9 back in 2012 …

@mfournier mfournier merged commit 8476eff into collectd:collectd-5.6 Oct 4, 2016
@octo octo added Fix A pull request fixing a bug and removed Bug A genuine bug labels Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build An issue with the build Fix A pull request fixing a bug Pending contributor action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants