-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GenericJMX plugin: Support boolean input #3044
Conversation
cc @rubenk Hi, Ruben! What do you think, should this file being checked by |
Good point: the If we're going the formatting route, I'd prefer to reformat the files (without changes) separately, then re-base this PR on top of that. |
Added "ChangeLog: …" line to the pull request description |
How do I trigger a check rerun? |
@Caden94, closing pull request and then opening same pull request again on github was re-triggering some checks but I don't know if ChangeLog check can be re-triggered that way - I think you can try it. |
Hi @Caden94, the Also, #3061 aims at improving the docs around this; your input would be very helpful :) Best regards, |
Thanks @octo for improving the documentation. |
Hi Team, please let me know if anything needs to be revised. |
Ping! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The actual change is rather trivial, but obstructed by the massive reformatting. I just verified the first commit containing the real change.
ChangeLog: GenericJMX plugin: Support boolean input.