Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GenericJMX plugin: Support boolean input #3044

Merged
merged 4 commits into from
Feb 29, 2020
Merged

Conversation

Caden94
Copy link
Contributor

@Caden94 Caden94 commented Jan 22, 2019

ChangeLog: GenericJMX plugin: Support boolean input.

@rpv-tomsk
Copy link
Contributor

cc @rubenk

Hi, Ruben!

What do you think, should this file being checked by clang-format or not?

@octo
Copy link
Member

octo commented Feb 6, 2019

Good point: the .java files have not yet been re-formatted, but it appears that the bot is checking them, too. Both, excluding Java files from the check and formatting the files works for me, with a preference for formatting the files. What are your thoughts?

If we're going the formatting route, I'd prefer to reformat the files (without changes) separately, then re-base this PR on top of that.

@octo octo changed the title Support boolean input GenericJMC plugin: Support boolean input Feb 6, 2019
@octo octo changed the title GenericJMC plugin: Support boolean input GenericJMX plugin: Support boolean input Feb 6, 2019
@octo octo added the Feature label Feb 6, 2019
@Caden94
Copy link
Contributor Author

Caden94 commented Feb 6, 2019

Added "ChangeLog: …" line to the pull request description

@Caden94
Copy link
Contributor Author

Caden94 commented Feb 6, 2019

How do I trigger a check rerun?

@rjablonx
Copy link
Contributor

rjablonx commented Feb 7, 2019

@Caden94, closing pull request and then opening same pull request again on github was re-triggering some checks but I don't know if ChangeLog check can be re-triggered that way - I think you can try it.

@octo
Copy link
Member

octo commented Feb 7, 2019

Hi @Caden94,

the ChangeLog: … line needs to be added to the PR description, not the commit message. You can edit the PR description by going to the first entry, click on the three dots () in the upper right corner and select "Edit".

Also, #3061 aims at improving the docs around this; your input would be very helpful :)

Best regards,
—octo

@Caden94 Caden94 closed this Feb 11, 2019
@Caden94 Caden94 reopened this Feb 11, 2019
@Caden94 Caden94 closed this Feb 11, 2019
@Caden94 Caden94 reopened this Feb 11, 2019
@Caden94 Caden94 closed this Feb 11, 2019
@Caden94 Caden94 reopened this Feb 11, 2019
@Caden94
Copy link
Contributor Author

Caden94 commented Feb 11, 2019

@Caden94, closing pull request and then opening same pull request again on github was re-triggering some checks but I don't know if ChangeLog check can be re-triggered that way - I think you can try it.

Thanks @rjablonx reopen works for me.

@Caden94
Copy link
Contributor Author

Caden94 commented Feb 11, 2019

Hi @Caden94,

the ChangeLog: … line needs to be added to the PR description, not the commit message. You can edit the PR description by going to the first entry, click on the three dots () in the upper right corner and select "Edit".

Also, #3061 aims at improving the docs around this; your input would be very helpful :)

Best regards,
—octo

Thanks @octo for improving the documentation.

@Caden94
Copy link
Contributor Author

Caden94 commented Feb 19, 2019

Hi Team, please let me know if anything needs to be revised.

@Caden94
Copy link
Contributor Author

Caden94 commented Feb 21, 2019

Ping!

Copy link
Contributor

@dago dago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actual change is rather trivial, but obstructed by the massive reformatting. I just verified the first commit containing the real change.

@dago dago merged commit 2756414 into collectd:master Feb 29, 2020
@dago dago added this to the 5.11.0 milestone Feb 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants