Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$< used in non-suffix rules #3313

Closed
efuss opened this issue Oct 15, 2019 · 2 comments · Fixed by #3376
Closed

$< used in non-suffix rules #3313

efuss opened this issue Oct 15, 2019 · 2 comments · Fixed by #3376

Comments

@efuss
Copy link
Contributor

efuss commented Oct 15, 2019

  • Version of collectd: 5.8.0
  • Operating system / distribution: NetBSD
  • Kernel version (if applicable):

Expected behavior

Building grpc working with non-GNU make

Actual behavior

Building grpc plugin fails with protoc being called with no input files.

Steps to reproduce

Build grpc plugin with bmake.

Makefile.ac, for the collectd.grpc.pb.cc and collectd.pb.cc targets, uses $< (implied source) in the rule calling protoc, which is only valid for suffix (inference) rules. That should be $> (all sources) or spelled out.

@rubenk
Copy link
Contributor

rubenk commented Oct 29, 2019

If you could send a PR which doesn't break building with Gnu Make I'd be willing to accept it.

@efuss
Copy link
Contributor Author

efuss commented Oct 29, 2019

#3330. I hope I didn't mix anything up (I'm more familiar with sending patches than Pull Requests).

This was linked to pull requests Feb 17, 2020
wip-sync pushed a commit to NetBSD/pkgsrc-wip that referenced this issue Jul 20, 2020
Don't use $< (implied source) in non-suffix rules, use $> instead.
collectd/collectd#3313
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants