Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix of "Implement the NFS plugin for NetBSD #3333" #3377

Merged
merged 6 commits into from
Feb 21, 2020

Conversation

dago
Copy link
Contributor

@dago dago commented Feb 18, 2020

ChangeLog: NFS plugin: An implementation for NetBSD (using sysctl) has been added.

efuss and others added 5 commits October 31, 2019 17:57
Re-format some lines to appease clang-format.

clang-format also wants to change the indentation of some #endif comments I didn't introduce and re-order #include's into a form that /does not compile/.
@dago dago added this to the 5.11.0 milestone Feb 18, 2020
@dago dago requested a review from mrunge February 18, 2020 15:59
Copy link
Member

@kwiatrox kwiatrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @dago, I added some minor comment to original code.

src/nfs.c Show resolved Hide resolved
src/nfs.c Outdated Show resolved Hide resolved
src/nfs.c Show resolved Hide resolved
Copy link
Member

@kwiatrox kwiatrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants