5.1 Build failure for Solaris 10

[jblaine]

:(

collectd-5.1.0:cairo> uname -a
SunOS cairo.our.org 5.10 Generic_144488-17 sun4u sparc SUNW,Sun-Fire-280R
collectd-5.1.0:cairo> echo $PATH
/usr/bin:/bin:/usr/sfw/bin:/usr/ccs/bin:/sbin:/usr/sbin
collectd-5.1.0:cairo> ./configure --prefix=/usr/rcf-tools/collectd-5.1.0 --enable-all-plugins
...
collectd-5.1.0:cairo> make 2>&1 | tee make.log
...
nfs.c: In function `nfs_read_kstat':
nfs.c:335: warning: passing arg 2 of `get_kstat_value' discards qualifiers from pointer target type
*** Error code 1
make: Fatal error: Command failed for target `nfs.lo'
...

[jblaine]

Using --disable-nfs (booooo) leads to the same error when it gets to building the zfs-arc stuff. Bummed!

Though adding --disable-zfs-arc gets me a build at least.

[jblaine]

Interesting. Built fine with Solaris Studio 12. Maybe need to mention that in the INSTALL?

Update: Well, so much for that. It crashes after 1 iteration with the same ksp != NULL assertion issue #71 :)

[octo]

The argument is not const, because of a stupid interface that is used:

void *kstat_data_lookup(kstat_t *ksp, char *name);

[ymettier]

This patch contains a strange modification :

-    const char **proc_names, size_t proc_names_num)
+    char const **proc_names, size_t proc_names_num)

The syntax should be const char, shouldn't it ?

Yves

[rubenk]

It doesn't matter. const is a type qualifier, char is a type specifier, and the ordering is not specified afaik.