Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: sys/types is already included in collectd.h #1180

Closed
wants to merge 1 commit into from
Closed

core: sys/types is already included in collectd.h #1180

wants to merge 1 commit into from

Conversation

rubenk
Copy link
Contributor

@rubenk rubenk commented Aug 1, 2015

No description provided.

@pyr
Copy link
Member

pyr commented Aug 5, 2015

@rubenk is this fixing any error on some system ? <sys/types.h> is usually protected against multiple includes.

@rubenk
Copy link
Contributor Author

rubenk commented Aug 5, 2015

@pyr, no just good practice. We check for <sys/types.h> with ./configure but don't wrap it in HAVE_SYS_TYPES_H everywhere. If we only include it from collectd.h there's less change for plugin authors to do it wrong.

@pyr
Copy link
Member

pyr commented Aug 5, 2015

@rubenk I think the check for sys/types.h can be killed, we're not going to be in luck on a system where that doesn't exist :-) If you really want to work on a PR in that space, you can kill the sys/types.h check and remove the #ifdefs.

@rubenk
Copy link
Contributor Author

rubenk commented Aug 5, 2015

Ok, I'll do that in a separate PR, thanks.

@rubenk rubenk closed this Aug 5, 2015
@rubenk rubenk deleted the core/use-sys-types-from-collectd-h branch August 5, 2015 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants