Set SNMP ASN_GAUGE values to unsigned. #1325
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated the PR to fix clang complaining about extraneous parenthesis. |
|
Thanks for figuring this out @nward ! The reasoning seems to match what one can read on the topic in rfc1902. I'll leave this open for a few more days so that others can review, but AFAIC it's good to go. |
|
As a data point, I've been running this in production for a few days now, no problems with any other stats - and we have.. lots. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SNMP-SMIv2 specifies Gauge32 as unsigned, however the change to fix #50, which was this exact problem, set both Integer and Gauge to signed, when it should have only set Integer.
This patch sets Gauge32 to be unsigned.