Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memcached_connections is of type GAUGE, needs to be submitted as a gauge. #1356

Closed
wants to merge 1 commit into from

Conversation

coreykosak
Copy link
Contributor

Put another way, line 442 needs to be consistent with line 438.

(credit: Jason Lawrence (https://github.com/chroniton) for finding this).

@mfournier
Copy link

Thanks a lot @coreykosak !

I just want to be sure this is the right fix. According to fa91b25, this value is "a counter which increments when the connection limit to memcached is reached and a socket listen is disabled."

If this is correct, submitting it as a derive is right, but the chosen data type is not.

What do you think ?

@octo
Copy link
Member

octo commented Nov 26, 2015

Thanks @coreykosak! Agreed, lines 438 and 442 contradict. If this is indeed a counter, another type has to be used.

@octo
Copy link
Member

octo commented Nov 26, 2015

According to https://code.google.com/p/memcached/wiki/NewServerMaint and https://code.google.com/p/memcached/wiki/Timeouts, listen_disabled_num is a counter. I think this line should therefore be:

submit_derive ("connections", "listen_disabled", atof (fields[2]), st);
/*              ^^^^^^^^^^^ */

@octo octo added the Bug A genuine bug label Dec 1, 2015
@octo octo added this to the 5.5 milestone Dec 1, 2015
@octo octo closed this Dec 1, 2015
coreykosak pushed a commit to Stackdriver/collectd that referenced this pull request Dec 3, 2015
@coreykosak coreykosak deleted the memcached-gauge branch August 6, 2016 00:43
@rpv-tomsk
Copy link
Contributor

rpv-tomsk commented Jul 30, 2017

If this is correct, submitting it as a derive is right, but the chosen data type is not.

What do you think ?

Yes, choosen data type is incorrect. That is not 'connections', but a 'counter how many times limit was reached'. We are unable to know, how many connections was lost because of that.
We need to register another issue about this. Added: #2386

@octo octo added Fix A pull request fixing a bug and removed Bug A genuine bug labels Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix A pull request fixing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants