Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* Collectd::Unixsock: Split messages sent by flush() to 1024 byte chunks to not overflow buffer in unixsock.c us_handle_client(). #1557

Merged
merged 1 commit into from Apr 24, 2016

Conversation

rpv-tomsk
Copy link
Contributor

Collection3 scripts generates commands of huge length when many files needs to be flushed.

This causes errors in web-server logs like this:

index.cgi: FLUSH failed: Parsing options failed. at ../lib/Collectd/Graph/Common.pm

And errors from collectd like this:

collectd[1243]: unixsock plugin: failed to write to socket #8: Broken pipe

Proposed patch splits FLUSH to separate commands. We have used this in production for a long time, and I think it will be useful for others too.

…nks to not overflow buffer in unixsock.c us_handle_client().
@rubenk
Copy link
Contributor

rubenk commented Mar 13, 2016

Please rebase and squash.

@rpv-tomsk
Copy link
Contributor Author

Updated.

@rubenk rubenk merged commit 01e2d29 into collectd:master Apr 24, 2016
@rubenk
Copy link
Contributor

rubenk commented Apr 24, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants