-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port to Sailfish OS #1736
Open
rinigus
wants to merge
19
commits into
collectd:main
Choose a base branch
from
rinigus:sfos_port
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Port to Sailfish OS #1736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mandline for that in Sailfish
…ges in default config
… through background_activity_ functions
Merged
@octo: I guess, this is too big to be realistically included into 5.7 . Unless you guys looked into it already. As far as I can see, there are maybe up to 500-600 installations of it and I have not heard any complains regarding the collectd process. Anyway, collectd is used by quite a few people now to check the device performance and debug the problems with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pull request introducing Sailfish OS port of collectd. The port is described in included README.md. The implementation details and possible problems are given below as well (same text as in the corresponding section in readme).
Looking forward to your feedback.
Implementation details:
The changes in the code were done in src/daemon/collectd.c . Instead
of calling "do_loop", glib main loop was created and used. By using
keepalive library ( https://git.merproject.org/mer-core/nemo-keepalive
), background activity interval was specified and, through glib, its
calling the callback function "do_shot". In the end of "do_shot", a
continuation of the loop is requested by calling
"background_activity_wait". Note that after calling
"background_activity_wait", device could suspend again.
The initialization, signal callbacks, and cleanup on shutdown were
rewritten as well. To avoid compilation warnings, "do_loop" is
preprocessed out if HAVE_KEEPALIVE_GLIB is defined.
As far as I understand, the main problem with the implementation is
caused by multi-threaded approach to reading the data by
collectd. From reading the code, I am not sure whether after exiting
plugin_read_all all plugins have finished reading. For fully correct
implementation, that should be the case. If it is not the case, it
would be great if someone with knowledge of collectd would step in and
help to implement this call as needed.
In practice, on Nexus 4 SFOS port, every wakeup takes at least 6
seconds and within that time all plugins have been updated, as far as
I could see from the graphs.