Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to Sailfish OS #1736

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Port to Sailfish OS #1736

wants to merge 19 commits into from

Conversation

rinigus
Copy link
Contributor

@rinigus rinigus commented May 31, 2016

This is a pull request introducing Sailfish OS port of collectd. The port is described in included README.md. The implementation details and possible problems are given below as well (same text as in the corresponding section in readme).

Looking forward to your feedback.

Implementation details:

The changes in the code were done in src/daemon/collectd.c . Instead
of calling "do_loop", glib main loop was created and used. By using
keepalive library ( https://git.merproject.org/mer-core/nemo-keepalive
), background activity interval was specified and, through glib, its
calling the callback function "do_shot". In the end of "do_shot", a
continuation of the loop is requested by calling
"background_activity_wait". Note that after calling
"background_activity_wait", device could suspend again.

The initialization, signal callbacks, and cleanup on shutdown were
rewritten as well. To avoid compilation warnings, "do_loop" is
preprocessed out if HAVE_KEEPALIVE_GLIB is defined.

As far as I understand, the main problem with the implementation is
caused by multi-threaded approach to reading the data by
collectd. From reading the code, I am not sure whether after exiting
plugin_read_all all plugins have finished reading. For fully correct
implementation, that should be the case. If it is not the case, it
would be great if someone with knowledge of collectd would step in and
help to implement this call as needed.

In practice, on Nexus 4 SFOS port, every wakeup takes at least 6
seconds and within that time all plugins have been updated, as far as
I could see from the graphs.

@rinigus
Copy link
Contributor Author

rinigus commented Nov 8, 2016

@octo: I guess, this is too big to be realistically included into 5.7 . Unless you guys looked into it already.

As far as I can see, there are maybe up to 500-600 installations of it and I have not heard any complains regarding the collectd process. Anyway, collectd is used by quite a few people now to check the device performance and debug the problems with it.

@collectd-bot collectd-bot changed the base branch from master to main July 3, 2020 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants