Set _GNU_SOURCE globally #1880
Closed
Set _GNU_SOURCE globally #1880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One minor issue is that Python.h unconditionally defines _GNU_SOURCE (https://bugs.python.org/issue1045893) so we need to use AH_VERBATIM instead of AC_DEFINE.
Now that we set _GNU_SOURCE globally it isn't needed anymore.
|
I'm a bit conflicted with this one: on the one hand I don't want contributors to dive into unnecessary GNUisms, on the other hand the continuous integration hooks will let us know when something is truly not portable. |
|
Indeed. I did this primarily for Solaris, but now that we have Solaris builders, this is not a big issue anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One minor issue is that Python.h unconditionally defines
_GNU_SOURCE (https://bugs.python.org/issue1045893) so we
need to use AH_VERBATIM instead of AC_DEFINE.