[WIP] Knot Plugin #2649
Closed
[WIP] Knot Plugin #2649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianbrost
force-pushed
the
knot-plugin
branch
3 times, most recently
from
212f686
to
bc4163f
Compare
This is not complete so far, it still misses proper dependency checks in the build system and documentation.
julianbrost
force-pushed
the
knot-plugin
branch
from
bc4163f
to
2bbac50
Compare
|
I'm closing this as I probably won't put more work into this. If anyone wants to take over, feel free to use this as the base for your own PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implementes a new plugin that allows collecting metrics from the Knot DNS server from its UNIX domain socket using libknot.
It's still work in progress. The logic should be done but the handling of the individual metrics is not fully done. A few values are not handled at all (see TODO comment in the source), some like reply-size also don't really make sense to periodically collect in my opinion, so they probably won't be implemented at all (Knot keeps counters for packet sizes in 256 buckets, I think it makes more sense to just plot the total number as a histogram, but not in a collectd plugin I guess).
The second open question corresponds to types. For most of the metrics, there already exist types in types.db. Unfortunately, the dns_octets type doesn't fit the request-bytes/response-bytes as it has both rx and tx values as there is no direct 1:1 mapping between requests (query, update, other) and and reponses (reply, transfer, other). For now, I've just used some other types which kind of fit, but maybe this justifies adding a new type?